-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: poc octo run list #638
Conversation
Using graphql is not a big deal. Just use whatever endpoint that works. Think there are a few non graphql commands used. |
Ah okay, functionality wise, do you have any feedback? |
I will give it a try when I can! |
Think it looks good. Would you want to make use of the pickers instead of the new, custom buffer? I have been using telescope recently. What do you use? Some items:
|
|
You still want there to be a buffer when you press |
Thanks for the PR @GustavEikaas! I like the idea of showing the status of the run in the preview buffer and perhaps show the logs of the run upon opening the item with |
IIRC the sequential jobs is already supported but yes I was thinking the same. |
@pwntester |
Doesnt seem like there is a good structured output for workflow logs. Will probably be tricky to have the same UI as github web. |
Nice, perhaps we can do a nested telescope selection where the use first chooses the run and then the job, that should get us a shorter log to show to the user and it should easier to print since we dont need to care about job's dependencies, just sequential steps |
Ill keep digging! It would be easier if anyone could link me a specific workflow run that causes it to error out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
Also, been thinking about the use of zip files (Still don't have working in all cases for me)...
Do the logs have to stored to file system? There are other items that are just stored in the local variable M
. Can that strategy also be used?
Github supports two ways of giving workflow logs.
I dont necessarily have to write the zip archive to disk but I need some sort of tool/library to extract the files from the zip archive for me. There is no inbuilt lua/vim support for zip archives. I chose unzip because it is included when installing git. AFAIK unzip doesnt accept inline zip archive as stdio. If you know of any other ways to do this im all ears. I looked a bit more into the issue and I can no longer repro the issue but apparently you can. Do you have any repro on a public OSS repo where you can link me the workflow run. If I can repro the issue I can probably fix it |
Overall, it seems to be working fairly well for most cases. I can get some on the second try. I am having trouble with: EDIT: I added the |
Some other nice to have features:
|
Other than that, think this is pretty much good to go. We can get it out, people can try, and we iterate! It's awesome addition so thanks for all of the back and forth! |
I see the issue with the workflow run you linked @wd60622 TLDR; main issue is length being truncated. Honestly dont know how to work around this without making a bunch of code for processing and transforming paths and filenames. I'm afraid it will never be 100% with this approach |
Made a final attempt using some wildcard tricks. @wd60622. |
Will take a look tomorrow and let you know how it goes Is there a Json payload that comes back too? Maybe we can use some type of id instead of a raw name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, more successes than failures! But let's get this through. Awesome feature! 🚀
Thanks! It's been a journey, mostly fun though. Glad we could finally release it! Feel free to tag me in any future issues relating to this. |
Totally, I know how it goes. Thanks for sticking in there. Feel free to open Issues for any features as well. |
Important
This is a draft PR
Im making this draft PR so I can get reviews/suggestions during development
I will fill out the PR template when the PR is ready for review
Resolves: #149
Describe what this PR does / why we need it
First PR in a series of PRs to add support for github actions
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist
Feature checklist
##[group]
[command]
Remaining
Look into using graphql in favor of gh cli commands (not sure if strictly necessary but conforms to the repo standard)